gvfs-helper: retry when creating temp files - #231
Merged
Derrick Stolee (derrickstolee) merged 1 commit intoDec 31, 2019
Merged
Conversation
When we create temp files for downloading packs, we use a name based on the current timestamp. There is no randomness in the name, so we can have collisions in the same second. Retry the temp pack names using a new "-<retry>" suffix to the name before the ".temp". Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Derrick Stolee (derrickstolee)
requested a review
from Jeff Hostetler (jeffhostetler)
December 26, 2019 15:22
Jeff Hostetler (jeffhostetler)
approved these changes
Dec 30, 2019
Jeff Hostetler (jeffhostetler)
left a comment
Jeff Hostetler (jeffhostetler)
left a comment
There was a problem hiding this comment.
Wow! We got a collision in the concurrent test suite even with the microsecond value in the basename.
|
as an alternative, we could encode the PID in the tempfile pathname. |
Derrick Stolee (derrickstolee)
added a commit
to microsoft/scalar
that referenced
this pull request
Dec 31, 2019
These updates allow the gvfs-helper to be more resilient to concurrent pack downloads. See microsoft/git#229 and microsoft/git#231 for more details.
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Jan 14, 2020
When we create temp files for downloading packs, we use a name based on the current timestamp. There is no randomness in the name, so we can have collisions in the same second. Retry the temp pack names using a new "-<retry>" suffix to the name before the ".temp". This is a follow-up to #229.
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Feb 21, 2020
When we create temp files for downloading packs, we use a name based on the current timestamp. There is no randomness in the name, so we can have collisions in the same second. Retry the temp pack names using a new "-<retry>" suffix to the name before the ".temp". This is a follow-up to #229.
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Mar 17, 2020
When we create temp files for downloading packs, we use a name based on the current timestamp. There is no randomness in the name, so we can have collisions in the same second. Retry the temp pack names using a new "-<retry>" suffix to the name before the ".temp". This is a follow-up to #229.
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Mar 23, 2020
When we create temp files for downloading packs, we use a name based on the current timestamp. There is no randomness in the name, so we can have collisions in the same second. Retry the temp pack names using a new "-<retry>" suffix to the name before the ".temp". This is a follow-up to #229.
Johannes Schindelin (dscho)
pushed a commit
that referenced
this pull request
May 20, 2020
When we create temp files for downloading packs, we use a name based on the current timestamp. There is no randomness in the name, so we can have collisions in the same second. Retry the temp pack names using a new "-<retry>" suffix to the name before the ".temp". This is a follow-up to #229.
Johannes Schindelin (dscho)
pushed a commit
that referenced
this pull request
May 20, 2020
When we create temp files for downloading packs, we use a name based on the current timestamp. There is no randomness in the name, so we can have collisions in the same second. Retry the temp pack names using a new "-<retry>" suffix to the name before the ".temp". This is a follow-up to #229.
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Jun 1, 2020
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Jul 20, 2020
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Jul 27, 2020
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Jul 28, 2020
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Oct 6, 2020
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Oct 6, 2020
Johannes Schindelin (dscho)
pushed a commit
that referenced
this pull request
Oct 6, 2020
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Oct 9, 2020
Johannes Schindelin (dscho)
pushed a commit
that referenced
this pull request
Mar 4, 2021
Johannes Schindelin (dscho)
pushed a commit
that referenced
this pull request
Mar 5, 2021
Johannes Schindelin (dscho)
pushed a commit
that referenced
this pull request
Mar 8, 2021
Jeff Hostetler (jeffhostetler)
pushed a commit
that referenced
this pull request
Mar 15, 2021
Jeff Hostetler (jeffhostetler)
pushed a commit
that referenced
this pull request
Mar 16, 2021
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
May 17, 2021
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
May 17, 2021
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
May 17, 2021
Johannes Schindelin (dscho)
pushed a commit
that referenced
this pull request
May 21, 2021
Johannes Schindelin (dscho)
pushed a commit
that referenced
this pull request
May 22, 2021
Johannes Schindelin (dscho)
pushed a commit
that referenced
this pull request
May 22, 2021
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
May 28, 2021
Johannes Schindelin (dscho)
pushed a commit
that referenced
this pull request
Jun 2, 2021
Johannes Schindelin (dscho)
pushed a commit
that referenced
this pull request
Jun 7, 2021
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Aug 3, 2021
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Aug 3, 2021
Johannes Schindelin (dscho)
pushed a commit
that referenced
this pull request
Aug 5, 2021
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Aug 9, 2021
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Aug 12, 2021
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Aug 17, 2021
Johannes Schindelin (dscho)
pushed a commit
that referenced
this pull request
Oct 30, 2021
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Oct 30, 2021
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Oct 31, 2021
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Nov 4, 2021
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Nov 10, 2021
Derrick Stolee (derrickstolee)
added a commit
that referenced
this pull request
Nov 15, 2021
Lessley Dennington (ldennington)
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 12, 2022
Includes these pull requests: microsoft#227 microsoft#228 microsoft#229 microsoft#231 microsoft#240 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Lessley Dennington (ldennington)
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 19, 2022
Includes these pull requests: microsoft#227 microsoft#228 microsoft#229 microsoft#231 microsoft#240 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Lessley Dennington (ldennington)
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
Includes these pull requests: microsoft#227 microsoft#228 microsoft#229 microsoft#231 microsoft#240 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Lessley Dennington (ldennington)
pushed a commit
to ldennington/git
that referenced
this pull request
Jan 20, 2022
Includes these pull requests: microsoft#227 microsoft#228 microsoft#229 microsoft#231 microsoft#240 Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we create temp files for downloading packs, we use a name
based on the current timestamp. There is no randomness in the
name, so we can have collisions in the same second.
Retry the temp pack names using a new "-" suffix to the
name before the ".temp".
This is a follow-up to #229.